templates/rebase: add rhcos extensions container update step #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a step to update the Fedora version in the RHCOS extensions container Dockerfile.
jlebon
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
LGTM, though reading the original ticket, I do wonder if the ppc64le builder we're now using and the latest c9s/ubi9 images would still hit that issue. Might be worth checking. But not really a priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a step to the Fedora Rebase Checklist to update the Fedora version in the RHCOS extensions container Dockerfile.
We recently ran into a situation where the version hadn't been updated and it caused us some issues.
See: openshift/os#1545 and openshift/os#1550.
openshift/os#1546 aims to move away from using Fedora images for RHCOS and SCOS, so we may be able to remove this step in the future.